Support for the new --generate-json switch for analyzer to generate json file #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to generate an additional json file
Closed
1 task
simone-dbx-labs
had a problem deploying
to
tool
GitHub Actions
Failure
|
✅ 51/51 passed, 9 flaky, 4m13s total Flaky tests:
Running from acceptance #3033 |
simone-dbx-labs
temporarily deployed
to
tool
GitHub Actions
Inactive
simone-dbx-labs
temporarily deployed
to
tool
GitHub Actions
Inactive
simone-dbx-labs
temporarily deployed
to
tool
GitHub Actions
Inactive
…n-file-generation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
===========================================
- Coverage 65.23% 13.74% -51.50%
===========================================
Files 100 100
Lines 8504 8505 +1
Branches 875 875
===========================================
- Hits 5548 1169 -4379
- Misses 2769 7277 +4508
+ Partials 187 59 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lots of things have been changed since the last commit for this feature. next commit will have my changes added
…json flag - Updated Callable type signature to accept 5 parameters: (Path, Path, str, bool, bool) - Fixed argument order in analyzer call to match bladespector signature: (source_dir, tmp_dir, platform, is_debug, generate_json) - Ensures generate_json flag properly flows through to analyzer binary -j flag 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Added typing.cast to explicitly declare Analyzer.analyze signature - Fixes CI mypy error where external package type information wasn't available - Cast ensures Callable[[Path, Path, str, bool, bool], None] signature is recognized 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…n-file-generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modified the scripts to pass an additional --generate-json switch to analyzer.
Relevant implementation details
updated all the files responsible for enabling and propagating the new switch --generate-json for the analyzer
Linked issues
Resolves #..
#2010
Functionality
databricks labs lakebridge analyze --generate-jsonTests
not tested yet. Th exeisting functionality stays as is, with the new switch the analyzer produces an additional json file